Optionally set an Author on an Edition #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Generally looks good. A couple of things that might be good to address, and a couple of other more minor suggestions. I might also quickly run the broader idea past the team in our dev chat this afternoon
The labels/first lines of each of the comments here are following the Conventional Comments format, which I'm trying out after watching a useful DevOpsDays London talk
content_schemas/formats/shared/definitions/publishing_api_base.jsonnet
Outdated
Show resolved
Hide resolved
pezholio
force-pushed
the
content-modelling/632-spike-can-we-get-the-user-who-have-last-updated-a-piece-of-content
branch
3 times, most recently
from
94eba2d to
c2590b7
Compare
yndajas
reviewed
Oct 17, 2024
content_schemas/formats/shared/definitions/publishing_api_base.jsonnet
Outdated
Show resolved
Hide resolved
content_schemas/formats/shared/default_properties/publisher.jsonnet
Outdated
Show resolved
Hide resolved
This takes the UUID of the user who last edited the edition.
pezholio
force-pushed
the
content-modelling/632-spike-can-we-get-the-user-who-have-last-updated-a-piece-of-content
branch
from
c2590b7 to
eeb4a2e
Compare
yndajas
approved these changes
Oct 17, 2024
db/migrate/20241017080126_add_last_edited_by_editor_id_to_editions.rb
Outdated
Show resolved
Hide resolved
This ensures this value gets set if it is present. I’ve added some shared exampes to the new edition and previous draft integration specs, as these seemed like the best places for them to go.
This is currently only internal to the Publishing API, so does not need to be sent upstream.
pezholio
force-pushed
the
content-modelling/632-spike-can-we-get-the-user-who-have-last-updated-a-piece-of-content
branch
from
eeb4a2e to
cc2a00c
Compare
pezholio
deleted the
content-modelling/632-spike-can-we-get-the-user-who-have-last-updated-a-piece-of-content
branch
nacnudus
added a commit
to nacnudus/govuk-knowledge-graph-gcp
that referenced
this pull request
Oct 22, 2024
The editions table in the upstream Publishing API database has a new column, `last_edited_by_editor_id`, created in alphagov/publishing-api#2919. This broke the data pipeline, because the BigQuery schema of that table rejected the new column. The new column contains sensitive data, so it is only included in tables in the `publishing-api` and `private` datasets, which most users cannot access. It is explicitly omitted from the query that puts the data into more accessible datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Content Modelling, when viewing content that is dependent of a content block, we'd like to be able to see who last edited that content, so publishers can liaise with the "owner" of that content if, for example, a change to a content block will alter the meaning of the dependent content.
As the Content Block Manager is publishing app agnostic, we currently have no way of knowing who last touched a piece of content, as this information is only stored within the publishing app itself.
This PR adds a new
last_edited_byfield which can optionally be sent to the Publishing API. In future this will allow us to use the Embedded Content Endpoint to return information about authors (if it exists).The next step will be to update the presenters in the various publishing apps - trialing with Whitehall first.