Move creation of test user to global before/after hook

alphagov · Jun 20, 2024 · 919e0eb · 919e0eb
1 parent f47fa92
commit 919e0eb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -31,6 +31,15 @@
 
   config.include FactoryBot::Syntax::Methods
 
+  config.before(:all, type: :system) do
+    @user = create(:user)
+    GDS::SSO.test_user = @user
+  end
+
+  config.after(:all, type: :system) do
+    @user.destroy!
+  end
+
   config.before(:each, type: :system) do
     driven_by :rack_test
   end

diff --git a/spec/system/recommended_links_spec.rb b/spec/system/recommended_links_spec.rb
@@ -1,9 +1,5 @@
 RSpec.describe "Recommended links" do
   before do
-    # TODO: Refactor me out into a support file (once we have more system specs and old
-    # controller specs are gone that this might conflict with)
-    GDS::SSO.test_user = create(:user)
-
     stub_external_content_publisher
   end