Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffold for Controls #1240

Closed
wants to merge 6 commits into from
Closed

Add scaffold for Controls #1240

wants to merge 6 commits into from

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Jun 24, 2024

This adds a basic CRUD scaffold for controls.

Controls are rulesets defined in Search Admin (and eventually synchronised to Discovery Engine/Vertex AI Search in a future change) that allow us to override the results returned.

In theory, these controls can be quite complex, but our MVP will probably approximate the previous "best bets" functionality where search administrators can promote certain documents to rank higher for a given query ("boosting").


image
image
image

@leenagupte
Copy link
Contributor

leenagupte commented Jun 24, 2024

So the basic scaffolding code looks good. 🎉

What I'd really like to understand how Controls are going to work going forward. I think I'm missing some context as I'm not sure why this is being added now without the something that uses it, or if the "something" is being workedhe on right now.

So everything, (Best bets, etc) apart from Recommended (external) links will be stored as a Control? Will recommended links eventually be moved to the Control model, or will they stay separate?
Does that mean admins will be able to select from a list of Control types to add or view something?

At the moment, the Search Admin home page redirects to the "External links page". Will change too?

P.S. The changes was really easy to follow and review ⭐ and thanks for adding screenshots 🥇

@csutter
Copy link
Contributor Author

csutter commented Jul 9, 2024

Closed in favour of #1254 following a new design doc, which also incorporates some minor improvements.

@csutter csutter closed this Jul 9, 2024
@csutter csutter deleted the proto-controls branch July 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants