Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use policy_scope in users controllers #2522

Closed
wants to merge 3 commits into from

Conversation

chrisroos
Copy link
Contributor

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@floehopper
Copy link
Contributor

This looks like a good idea to me - I hadn't seen Pundit's verify_policy_scoped before. I wonder whether we should try to add it to ApplicationController like we already do for verify_authorized and as somewhat suggested by this Pundit documentation.

@chrisroos chrisroos force-pushed the use-policy-scope-in-users-controllers branch from 2316f9f to 717ac11 Compare November 20, 2023 11:21
@chrisroos
Copy link
Contributor Author

Closing for now. I might revisit this idea in future but it's not a priority at the moment.

@chrisroos chrisroos closed this Nov 29, 2023
@chrisroos chrisroos deleted the use-policy-scope-in-users-controllers branch January 3, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants