Update permission editing on users edit page #2530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
move-permission-editing
branch
6 times, most recently
from
a4c9f4e to
05fe065
Compare
TODO: Decide whether to fold this into previous commit. The logic in this policy applies irrespective of whether you're granting yourself, or someone else, access to an app.
chrisroos
force-pushed
the
move-permission-editing
branch
from
05fe065 to
dc21a33
Compare
TODO: Move the delete method logic to the SigninPermissionPolicy. In preparation for moving this to the top-level of Pundit policies so that we can use it when we introduce the ability to edit other users' permissions. Note the change of behaviour. A govuk admin no longer has to have access to the app in order to be able to delete a UserApplicationPermission.
chrisroos
force-pushed
the
move-permission-editing
branch
from
dc21a33 to
b8b73e8
Compare
TODO: Update tests
chrisroos
force-pushed
the
move-permission-editing
branch
from
b8b73e8 to
0252417
Compare
|
Closing as we're trying a slightly different approach in #2558. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application is owned by the Access & Permissions team.
Follow these steps if you are doing a Rails upgrade.