Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous improvements to admin forms for editing user #2531

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Miscellaneous improvements to admin forms for editing user #2531

merged 4 commits into from
Nov 20, 2023

Conversation

floehopper
Copy link
Contributor

@floehopper floehopper commented Nov 20, 2023 •
edited
Loading

@floehopper
Use User#exempt_from_2sv? in user form fields partial
f82b289 
This method is more intention-revealing than calling `Object#blank?` on
the return value from `User#reason_for_2sv_exemption`.
@floehopper
Invert if/else in user form fields partial
b972918 
Avoiding the `!` makes the code more readable.
@floehopper
Use block form of link_to in user form fields partial
273a458 
This is more readable and avoid having to call `String#html_safe`.

As suggested by @chrisroos.
@floehopper
Add cancel links to edit user name & email pages
acad2fd 
As per Calum's request [1].

[1]: https://trello.com/c/uZD2I9dj/129-migrate-users-edit-page-to-the-design-system#comment-655b5d001f25ad7a14ef951c
chrislo
chrislo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@chrislo chrislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@floehopper
Copy link
Contributor Author

Thanks, @chrislo! 🙏

@floehopper floehopper merged commit 9eeb7e5 into main Nov 20, 2023
11 checks passed
@floehopper floehopper deleted the misc-improvements-to-admin-forms-for-editing-user branch November 20, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislo chrislo chrislo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floehopper @chrislo