Bump factory_bot_rails from 6.2.0 to 6.4.0 #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
This application is owned by the Access & Permissions team. Follow these steps if you are doing a Rails upgrade. |
|
@dependabot rebase |
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.2.0 to 6.4.0. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v6.2.0...v6.4.0) --- updated-dependencies: - dependency-name: factory_bot_rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/factory_bot_rails-6.4.0
branch
from
556ea3a to
661de4d
Compare
Although top level traits (mixins) are allowed according to the docs[1], they appear to be broken in factory bot 6.4.0[2]. We were seeing the following error: NoMethodError: undefined method `<' for nil:NilClass if for_class < ActiveRecord::Base && for_class.primary_key == attribute.name.to_s When running either of the tests that used the `with_expired_confirmation_token` trait: - test/controllers/account/emails_controller_test.rb:99 - test/controllers/users/emails_controller_test.rb:277 Given that we're only using this trait in User factories I've moved it inside the User factory definition so that we can upgrade. [1]: https://thoughtbot.github.io/factory_bot/traits/mixins.html [2]: thoughtbot/factory_bot_rails#431
Although top level traits (mixins) are allowed according to the docs[1], they appear to be broken in factory bot 6.4.0[2]. We were seeing the following error: NoMethodError: undefined method `<' for nil:NilClass if for_class < ActiveRecord::Base && for_class.primary_key == attribute.name.to_s When running the tests that used the `in_organisation` trait. Given that we're only using this trait in User factories I've moved it inside the User factory definition so that we can upgrade. [1]: https://thoughtbot.github.io/factory_bot/traits/mixins.html [2]: thoughtbot/factory_bot_rails#431
chrisroos
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
We were seeing some failing tests after this upgrade because it seems that factory_bot 6.3.0 broke top-level traits (mixins) (see thoughtbot/factory_bot_rails#431). I've moved our top-level traits into the user factory which appears to have fixed the problem we're seeing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps factory_bot_rails from 6.2.0 to 6.4.0.
Release notes
Sourced from factory_bot_rails's releases.
Changelog
Sourced from factory_bot_rails's changelog.
Commits
3346305Bump to 6.4.0 [ci skip]438d035Bump to 6.3.0 [ci skip]f9a1e7cDepend on factory_bot 6.4.xfd1ca67s/eser/user/ (#422)659d74aAdd projections.json for Rails.vim support0040292Reject sequence definitions for Active Record primary keys (#419)a28bec8Bundler 2.4.19 removed the "Using " lines3995e62Add custom Rails generator in README.md [ci skip]a0adcccRemove references to travis30c85d5Expand matrix for more recent versionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)