Refactor supported permissions method #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gweaton
reviewed
Aug 13, 2024
The `sorted_supported_permissions_grantable_from_ui` method was getting a little complex, with a lot of conditional logic. This separates out the sorting and filtering, with the former the responsibility of the `SupportedPermission` model, and the latter remaining the responsibility of the `Doorkeeper::Application` model based on the passed in arguments In the `Doorkeeper::Application` tests, we're using [Mocha's with][1] with a block using [Minitest's assert_same_elements][2] to check that the array argument contains the same elements regardless of order Mocha does have various [ParameterMatchers][3], which can be used with `with`, but unfortunately not an equivalent of `assert_same_elements` or something like [Jest's expect.arrayContaining][4] [1]: https://mocha.jamesmead.org/Mocha/Expectation.html#with-instance_method [2]: https://www.rubydoc.info/gems/minitest-rails-shoulda/0.4.1/MiniTest%2FAssertions:assert_same_elements [3]: https://mocha.jamesmead.org/Mocha/ParameterMatchers.html [4]: https://jestjs.io/docs/expect#expectarraycontainingarray Co-authored-by: Ynda Jas <[email protected]>
brucebolt
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sorted_supported_permissions_grantable_from_uimethod was getting a little complex, with a lot of conditional logic. This separates out the sorting and filtering, with the former the responsibility of theSupportedPermissionmodel, and the latter remaining the responsibility of theDoorkeeper::Applicationmodel based on the passed in argumentsIn the
Doorkeeper::Applicationtests, we're using Mocha's with with a block using Minitest's assert_same_elements to check that the array argument contains the same elements regardless of orderMocha does have various ParameterMatchers, which can be used with
with, but unfortunately not an equivalent ofassert_same_elementsor something like Jest's expect.arrayContainingThis application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.