Fix permissions by non-GDS users Rake task #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
permissions_by_non_gds_users_fix
branch
from
06361cd to
84126fe
Compare
I noticed that the data had a lot of events in which permissions were added but not listed. Some of the permissions could have been removed, but there were too many for that to account for all the omissions. It turns out I was splitting the event logs' messages incorrectly, so the task was looking for e.g. "Editor" within an array like ["signin", " Editor"]. This revises the split to account for the programmatically-added whitespace, which should (correctly) result in more matches
yndajas
force-pushed
the
permissions_by_non_gds_users_fix
branch
from
84126fe to
c91723a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
I noticed that some the data had a lot of events in which permissions were added but not listed. Some of the permissions could have been removed, but there were too many. It turns out I was splitting the event log's message incorrectly, so the task was looking for e.g. "Editor" within an array like ["signin", " Editor"]. This revises the split to account for the programmatically-added whitespace, which should (correctly) result in more matches
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.