This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Bump selenium-webdriver from 3.142.7 to 4.1.0 #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
I had a quick go at testing this locally and it appears to work OK, aside from a few option tweaks. The only irritation is that we'll see a deprecation warning after every scenario until dbalatero/capybara-chromedriver-logger#34 is merged. |
dependabot
bot
force-pushed
the
dependabot/bundler/selenium-webdriver-4.1.0
branch
2 times, most recently
from
f29629e to
2482445
Compare
|
After this is merged, we can get rid of the deprecation messages by merging: #933 |
KludgeKML
force-pushed
the
dependabot/bundler/selenium-webdriver-4.1.0
branch
from
65d975e to
6fc5077
Compare
Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 3.142.7 to 4.1.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.1.0) --- updated-dependencies: - dependency-name: selenium-webdriver dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
KludgeKML
force-pushed
the
dependabot/bundler/selenium-webdriver-4.1.0
branch
2 times, most recently
from
289fc19 to
bada8ed
Compare
benthorner
reviewed
May 17, 2022
features/support/env.rb
Outdated
| options: options, | ||
| desired_capabilities: capabilities | ||
| ) | ||
| capabilities: capabilities |
There was a problem hiding this comment.
Suggested change
| capabilities: capabilities | |
| capabilities: [capabilities, options] |
According to the deprecation message we can just combine the two:
:options as a parameter for driver initialization is deprecated. Use :capabilities with an Array of value capabilities/options if necessary instead.
I've tested with an array and both sets are indeed passed forward.
Is there an advantage to the chromeOptions approach?
KludgeKML
force-pushed
the
dependabot/bundler/selenium-webdriver-4.1.0
branch
from
bada8ed to
998bc68
Compare
benthorner
approved these changes
May 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps selenium-webdriver from 3.142.7 to 4.1.0.
Release notes
Sourced from selenium-webdriver's releases.
... (truncated)
Changelog
Sourced from selenium-webdriver's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)