Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bundler and nokogiri #3547

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Upgrade bundler and nokogiri #3547

merged 1 commit into from
Dec 31, 2024

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Dec 27, 2024

Follow these steps if you are doing a Rails upgrade.

What

This PR is a substitute for #3545 as that PR did not include bundler upgrade, which is recommended by nokogiri.

Why

As a safer and more complete substitute for a dependabot PR which attempted to upgrade nokogiri.

@unoduetre unoduetre marked this pull request as ready for review December 27, 2024 15:21
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, good spot on the recommendation from the Nokogiri documentation, thanks for including a link to this in the PR description 👍

@unoduetre unoduetre merged commit cdf6605 into main Dec 31, 2024
11 checks passed
@unoduetre unoduetre deleted the upgrade-bundler branch December 31, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants