Dart sass #1661
Merged
Dart sass #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create `dartsass.builds` initializer and add all Sass files to be compiled. See https://github.com/rails/dartsass-rails#configuring-builds - Create .keep - Update manifest file to use /builds directory - Ignore /builds
- Also, turn digests off in development
- was getting `undefined method assets` when trying to build transition in docker - followed this advice to fix the problem: https://stackoverflow.com/questions/50984265/ruby-on-rails-console-undefined-method-assets
andysellick
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Aug 12, 2024
- change needed to support the switch to dart-sass for Sass compilation in alphagov/transition#1661
- relying upon glyphicons as part of bootstrap, but the Sass for that doesn't compile properly in dart-sass because it uses `url(font-path(path))` - instead copy the font-face declaration from bootstrap into our code, overridding the original with this one, which fixes the icon paths and the icons - see similar problem fixed in content-tagger: alphagov/content-tagger#1768
brucebolt
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate to dart sass from lib sass.
Relates to alphagov/govuk_publishing_components#4106
Note that this change relies upon a change in
govuk-docker, in this PR: alphagov/govuk-docker#771Why
All applications using
govuk_publishing_componentsshould be using dart sass, and some changes coming in that gem may cause errors if applications aren't using dart sass.Visual changes
None.
Trello card: https://trello.com/c/gW2NW1sB/239-fix-sass-compilation-warnings