Add a prototype page #118
Merged
Add a prototype page #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
approved these changes
Nov 11, 2024
source/prototype.html.md.erb
Outdated
|
|
||
| Current pages for comparison: [WCAG Primer: 1.1.1](sc/1.1.1) and [Test Guide: 1.1.1](https://github.com/alphagov/wcag-primer/wiki/1.1.1) | ||
|
|
||
| ## [WCAG says](https://www.w3.org/WAI/WCAG22/Understanding/non-text-content): |
There was a problem hiding this comment.
I think the link to the criterion might work better being part of the body content rather than being within the heading.
It seems a little confusing given the heading is itself an anchor point linked from the sidebar navigation, resulting in the page having two links labelled "WCAG says" that lead to different places.
There was a problem hiding this comment.
That makes sense, thanks. I've moved the link just below the heading, using the naming convention we currently use in the test guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds a prototype page to see how the WCAG Primer might look if merged with the Test Guide, for 1.1.1 Non-text Content.
It is not intended to be reachable from the rest of the WCAG Primer.