Improve error handling if process is killed #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Leo, I appreciate the PR, but this is the kind of change that must be made very carefully, if at all. And before making it, I need to fully understand the problem. And it would be best if it were accompanied with a test case. So, if you would, please open a bug report issue where we can discuss the problem and understand potential solutions. Feel free to link the PR on the issue. |
|
Certainly! Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I noticed that, at least on my machine, when the curl process is killed it does not reliably return with a status code above 90. For me, this currently leads to an incorrect error message when the process is killed.
This PR tries to fix that issue.