Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release script to prevent CI builds #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2016

We discussed adding the "magic CI word" in the tag message, but while
making the change, and doing some research, it does not feel totally
right. I think we should just fix the message of the commit we're
tagging this is the one that should skip CI, and hopefully it will
also apply to the tag.
Should we try this?

@ghost ghost assigned thibaultdalban Apr 5, 2016
@ghost ghost added the enhancement label Apr 5, 2016
@thibaultdalban
Copy link
Member

This change will remove the ability to let the CI deploy the application.
Skip the CI just for the tag build is the best option, but maybe it's not possible.

@ghost ghost force-pushed the feature/improve-relase_script-avoid_ci branch from c5e83e5 to 0c728fc Compare April 5, 2016 15:34
@ghost
Copy link
Author

ghost commented Apr 5, 2016

This change will remove the ability to let the CI deploy the application.

I didn't realize that at the time :/ It's fixed.

Skip the CI just for the tag build is the best option, but maybe it's not possible.

We can add the string (I updated the PR with the change on the tag
message), but it will "pollute" our tags.
Regarding codeship, I guess we need to try it to see how it will work.

@ghost
Copy link
Author

ghost commented Apr 8, 2016

FYI, I tried the change, and codeship will still trigger three builds
(master, develop, and the tag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant