Rename wasi-cross to wasm-cross #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerrorJack
reviewed
Aug 8, 2023
ghc.nix
Outdated
| @@ -270,7 +278,9 @@ hspkgs.shellFor rec { | |||
| ${lib.optionalString withDocs "export FONTCONFIG_FILE=${fonts}"} | |||
|
|
|||
| # N.B. This overrides CC, CONFIGURE_ARGS, etc. to configure the cross-compiler. | |||
| ${lib.optionalString withWasiSDK "addWasiSDKHook"} | |||
| # FIXME: This bit is undocumented so I don't know what effect renaming it to | |||
There was a problem hiding this comment.
It's defined at https://gitlab.haskell.org/ghc/ghc-wasm-meta/-/blob/master/pkgs/wasi-sdk-setup-hook.sh and sets up various env vars to override the existing toolchain provided by stdenv. So don't change the name, but indeed it might be worth adding a comment that refers to this url for clarity
TerrorJack
reviewed
Aug 8, 2023
chreekat
force-pushed
the
b/rename-wasm-cross
branch
from
f17573d
to
80bc9eb
Compare
|
Thanks @TerrorJack . I've done as you suggested. |
chreekat
force-pushed
the
b/rename-wasm-cross
branch
from
79b35a7
to
0ef25f7
Compare
Retains wasi-cross (and withWasiSDK) as backward compat synonyms.
chreekat
force-pushed
the
b/rename-wasm-cross
branch
from
0ef25f7
to
c75036f
Compare
TerrorJack
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retains wasi-cross (and withWasiSDK) as backward compat synonyms.
This is a followup to Ben's comment.
Note there is one FIXME [edit: resolved now] at the bottom of ghc.nix. I don't know what addWasiSDKHook is used for, if anything, so I haven't changed it.