ucm2: sof-soundwire: Use one file for speaker codec initialization #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perexg
force-pushed
the
sdw-spk
branch
4 times, most recently
from
12d8b57 to
5bf138b
Compare
Use macros to minimize configuration blocks. Signed-off-by: Jaroslav Kysela <[email protected]>
charleskeepax
suggested changes
Dec 7, 2023
| DisableSequence [ | ||
| cset "name='AMP${var:__Amp} Speaker Switch' 0" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Personally the ControlExists version seemed simpler, but I am happy with this if you prefer it.
| Macro.num5.cs42l43spk { ForAmps "[68]" Amp 5 } | ||
| Macro.num6.cs42l43spk { ForAmps "[68]" Amp 6 } | ||
| Macro.num7.cs42l43spk { ForAmps "8" Amp 7 } | ||
| Macro.num8.cs42l43spk { ForAmps "8" Amp 8 } |
There was a problem hiding this comment.
We should include odd number as well, we have seen a few models with odd number typically the odd speaker being a single sub-woofer.
We do also have a case of a development board which has speakers 1,2,7,8, technically its an 8 speaker board but a commonly used configuration is 4 channels. It is nice if the amp numbers can line up to the physical outputs in use.
There was a problem hiding this comment.
Ok, I replaced this with [2-8] like regex expressions in latest config.
cs35l56 is a boosted speaker amp, add UCM support for configurations with up to 8 amps. Signed-off-by: Charles Keepax <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
charleskeepax
approved these changes
Dec 7, 2023
perexg
pushed a commit
that referenced
this pull request
Jan 9, 2024
cs35l56 is a boosted speaker amp, add UCM support for configurations with up to 8 amps. Closes: #370 Signed-off-by: Charles Keepax <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use macros to minimize configuration blocks.