Skip to content

Commit

Permalink
[pfcp] sendto should always return OGS_OK (#81)
Browse files Browse the repository at this point in the history
sendto() was crashing the entire SMF when it received an EDESTADDRREQ error. True source of the error is unknown (maybe wireguard hiccupping? looks like the packet was sent out on the wrong wg tunnel) but regardless of the error we should actually just handle gracefully, log error, and move on. PFCP already has its own retrans/recovery mechanisms so loss here is irrelevant.
  • Loading branch information
spencersevilla committed Jan 24, 2024
1 parent 5287845 commit d616f6d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/pfcp/path.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ int ogs_pfcp_sendto(ogs_pfcp_node_t *node, ogs_pkbuf_t *pkbuf)
sock->fd, pkbuf->data, pkbuf->len,
OGS_ADDR(addr, buf), OGS_PORT(addr));
}
return OGS_ERROR;
}

return OGS_OK;
Expand Down

0 comments on commit d616f6d

Please sign in to comment.