Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prost and tonic to latest and rebuild protos #7

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

jkilpatr
Copy link
Member

@jkilpatr jkilpatr commented Oct 3, 2024

The changes for this where pretty minor. Other than the usual hand massaging for namespace collisions the newest version of prost_build does not automatically package protoc, but using a protoc-src crate we are able to restore the previous behavior of compiling it on the fly rather than expecting the source machine to have it installed.

This patch upgrades prost and tonic to the latest versions and gets the
proto builder running with them. The second commit will include actual
upgraded protos.
Copy link
Collaborator

@ChristianBorst ChristianBorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

These versions all use the latest prost and tonic
@jkilpatr jkilpatr merged commit 85e2043 into main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants