Add to_bytes to identity #1030
Merged
Add to_bytes to identity #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkilpatr
force-pushed
the
jkilpatr/identity-to-from-bytes
branch
from
b5f3f44 to
6f49ed2
Compare
The get_hash and get_hash_array functions are unstable between rust versions due to changes in the internal hashing function. This patch adds deprecation tags to these functions and implements a to and from bytes representation for the Identity struct. This is distinct from the Ethereum ABI functions, as the byte representation is entierly defined by the Identity struct and not the Ethereum standard. As such it's a lot more straightforward to implement. The downside is that the new implementation is quite a bit larger than the old hash implementation at 68 bytes versus 8 bytes. But that's not really a big deal, for 5000 routers thats an extra 300MB of data used in indexing. Furthermore there's no risk of someone trying to generate an Identity with a hash collision.
jkilpatr
force-pushed
the
jkilpatr/identity-to-from-bytes
branch
from
6f49ed2 to
cde7bd8
Compare
ch-iara
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_hash and get_hash_array functions are unstable between rust versions due to changes in the internal hashing function. This patch adds deprecation tags to these functions and implements a to and from bytes representation for the Identity struct.
This is distinct from the Ethereum ABI functions, as the byte representation is entierly defined by the Identity struct and not the Ethereum standard. As such it's a lot more straightforward to implement.
The downside is that the new implementation is quite a bit larger than the old hash implementation at 68 bytes versus 8 bytes. But that's not really a big deal, for 5000 routers thats an extra 300MB of data used in indexing. Furthermore there's no risk of someone trying to generate an Identity with a hash collision.