Add bulk registration to AltheaDB #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this chunk based decoding scheme is pretty well setup as a quick fuzz at least can't find any unepected panics.
Solidity functions are standardized on snake case rather than camel case. If we don't fix this it looks strange in all explorers.
ChristianBorst
approved these changes
Nov 27, 2023
jkilpatr
force-pushed
the
jkilpatr/add-bulk-reg
branch
2 times, most recently
from
39fcf80 to
cf92385
Compare
Managing bulk registrations via transaction batching was too complex compared to simply adding an endpoint to the contract allowing for bulk registration. This new solution is much much easier to handle logistically.
jkilpatr
force-pushed
the
jkilpatr/add-bulk-reg
branch
3 times, most recently
from
027ef52 to
e3aaeb7
Compare
This patch includes a few cleanups for the exit, first off we fix the ctrl-c handler which means the exit restarts gracefully when you ask it to do so. Essential behavior. Next we remove hte --future agrument that has never been used and finally we change the internal config passing to Pathbuf to match rita client
jkilpatr
force-pushed
the
jkilpatr/add-bulk-reg
branch
from
e3aaeb7 to
4728a66
Compare
There shouldn't be two keys both called 'the miner key'
jkilpatr
force-pushed
the
jkilpatr/add-bulk-reg
branch
from
26c205d to
d0bf08a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds bulk registration as an endpoint to the AltheaDB.sol contract. This is much easier to manage than sending thousands of transactions to register and migrate users.