Add contract-utils binary #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes the existing migration util into a more generic utility for interacting with the exit database smart contract.
jkilpatr
force-pushed
the
jkilpatr/add-exit-register-tool
branch
from
1ff76bc to
93ec88c
Compare
This commit modifies the way the exit handles users list queries to be in line with the operating philosophy we usually use. Which is to crash quickly if the initial configuration or state is not correct. But one running the system should remain running if at all possible. Previously we tried to query the users list for 5 minutes before crashing. This is kinda the worst of both worlds, it won't be caught by a deployment script just checking for quick crashes and it also takes down the application any time we lose connection to the full node for more than 5 minutes The new design ensures that an already running exit will ride through, and that the program wil crash quickly if not configured properly on startup.
this helps handle strange edge cases where the router is configured to speak to a specific exit (therefore trusting it implicitly)
This patch expands the internal regions representation to represent all two letter ISO country codes, allowing us to drop raw strings in the config and ensure that region locking works properly on the new exit registration contract.
jkilpatr
force-pushed
the
jkilpatr/add-exit-register-tool
branch
from
0cbefa3 to
a45a0b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the existing migration util into a more generic utility for interacting with the exit database smart contract.