Fix peer enforcement when payment issues are ongoing #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty classic case of optimization causing problems. In order to try and optimize tunnel handling on routers with many tunnels we gated running the enforcmenet update code so that it was only run when there was an actual change to execute. At a later date we came along and added a check there to prevent running enforcement code if we where having full node issues, but the other case was never considered. What if someone needed to be unenforced while payment issues where occuring? This patch fixes the issue by removing some of the optimization and checking over enforcement more consistently to avoid users getting stuck in one wrong state or othe other. I also cleaned up some old actix artifacts.
ch-iara
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty classic case of optimization causing problems. In order to try and optimize tunnel handling on routers with many tunnels we gated running the enforcmenet update code so that it was only run when there was an actual change to execute.
At a later date we came along and added a check there to prevent running enforcement code if we where having full node issues, but the other case was never considered. What if someone needed to be unenforced while payment issues where occuring?
This patch fixes the issue by removing some of the optimization and checking over enforcement more consistently to avoid users getting stuck in one wrong state or othe other.
I also cleaned up some old actix artifacts.