Chiara/cherrypicking master #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a simple parser for /proc/net/dev that allows the caller to get the data usage counter for any interface. This is useful for various applciations for example we could display usage per port on the lan interfaces page.
We switched to Telnyx for SMS registration functions a while ago, so we don't actually have api keys to run the previous code. Also the phone number parsing logic has been refined to be slightly less complicated.
This patch removes cruft around startup args for Rita and modifies the default configuration file behavior to generate the config if one is not found. Previously I didn't think generating a config was valuable as a feature. But recently I've see strange behavior on some devices with limited storage where the config was no longer present.
This is a real unforced error of a bug, obviously the char representation of the octets can exceed u32 match because of the way it is translated into more significant bits when parsed. This is probably having a negative impact on exit enforcement in production.
Previously it was possible for this to panic on some invalid utf8 cases.
This patch represents a complete overhaul of the automated rescue systems in rita 1) everywhere where we used to try and crash actix to force a restart, we instead do a system reboot. Logs show these rescue functions are invoked pretty often, but killing the actix thread does not actually stop Rita like was originally hoped leaving routers in a bad state 2) The ping check that's used to reboot client routers when they can't reach the internet has been overhauld to ping a lot more destinations and combined with the hAP overload check For (1) I've been looking for the reason routers would simply stop opening tunnels and operating correctly. Reviewing this broken loop rescue behavior seems like a smoking gun for that sort of bug.
These continue to be difficult to maintain, especially considering we don't really use any mips target routers anymore as the processing power is too low.
jkilpatr
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAYMENTS_ALTHEA test currently failing for tx parsing