Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

オーナーをリポジトリ全体はエンジニア、記事全体は社員、エンジニアリング記事はエンジニアに設定 #85

Merged
merged 1 commit into from
Mar 4, 2024
Merged

オーナーをリポジトリ全体はエンジニア、記事全体は社員、エンジニアリング記事はエンジニアに設定 #85

merged 1 commit into from
Mar 4, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Mar 4, 2024

🙌 やったこと

  • CODEOWNERSを調整
    • リポジトリ全体はエンジニア（設定ファイルなど）
    • ハンドブック記事全体は社員
    • エンジニアリング記事配下はエンジニアに設定

📝 その他

@riscait riscait requested a review from a team as a code owner March 4, 2024 02:51
@riscait riscait requested review from naipaka and k-nkmr and removed request for a team March 4, 2024 02:51
naipaka
naipaka approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
設定調整ありがとうございます！

@riscait riscait merged commit 003ed67 into main Mar 4, 2024
1 check passed
@riscait riscait deleted the update-codeowners branch March 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naipaka naipaka naipaka approved these changes

@k-nkmr k-nkmr Awaiting requested review from k-nkmr k-nkmr was automatically assigned from altive/employees

Assignees

@riscait riscait

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riscait @naipaka