Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

紙・電子書籍購入時の概要と手順を作成しました #86

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

Aimiee01
Copy link
Contributor

@Aimiee01 Aimiee01 commented Mar 4, 2024

🙌 やったこと

✍️ やらないこと

📸 スクリーンショット

Before After
image image

📝 その他

@Aimiee01 Aimiee01 self-assigned this Mar 4, 2024
@Aimiee01 Aimiee01 requested a review from a team as a code owner March 4, 2024 07:40
@Aimiee01 Aimiee01 requested review from riscait, naipaka and k-nkmr and removed request for a team March 4, 2024 07:40
Comment on lines +51 to +53
{{< alert title="Note" >}}
経費には申請期限があります。
立替払いをした経費は、支払った月の末日が申請の期日なので注意してください。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badge
alert の閉じタグがないので追加が必要そう✍️

Comment on lines +67 to +68
[Altive社内図書](https://www.notion.so/altive/e3eabb8b7d4749b9a7afd3cbb7d0c7e6?v=1586bdd5f0f84199bff256337c00bdf2&pvs=4) に本を登録します。
登録内容については、既存の書籍を参考に記載してください。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

![badge](https://img.shields.io/badge/review-imo-important

(既存なら「届いた」ボタンで「持ってる人」に自分を追加)

すでに登録済みで、追加で購入した場合の説明が不足していそうです✍️

Comment on lines 2 to 3
title: "books purchasing"
linkTitle: "Short Nav Title"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badge
linkTitleの変更が必要そうです!
スクリーンショット 2024-03-05 13 52 09

titleも他と合わせて大文字始まりか日本語にした方が良さそうですかね✍️

linkTitleは省略しました。
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
追加ありがとうございます!🚀

Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aimiee01 Aimiee01 merged commit 6e687fe into main Mar 5, 2024
@Aimiee01 Aimiee01 deleted the books-purchasing branch March 5, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

書籍の購入について(紙・電子書籍)追記する
3 participants