Debian package fix lintian errors #437
Conversation
Use header level 2 for sections. Specify shell as language for commands.
…ep libs Two libraries are added manually because they aren't detected by shlibs
Also replace deprecated pkg-config with pkgconf
The CMake has a built-in variable BUILD_TESTING (default ON) to compile tests. When building a debian package, the debhelper configures the CMake with this option OFF. So now we don't need to pass the DADMC_BUILD_DEB=ON and we can simplify the debian/rules
There was a problem hiding this comment.
What is the purpose of modifying the README.md file in a pull request that specifically addresses Debian packaging? The changes to README.md are unrelated to the purpose of this pull request, please consider removing them and submitting a separate pull request for those changes if you still wish to update the file."
| @@ -52,9 +52,9 @@ include(ClangFormat) | |||
| option(ADMC_BUILD_DEB "Build the deb package of ADMC." OFF) | |||
|
|
|||
| add_subdirectory(src) | |||
| if(NOT ADMC_BUILD_DEB) | |||
| if(BUILD_TESTING) | |||
There was a problem hiding this comment.
If I recall correctly, the BUILD_TESTING variable is set up by CTest, which is not currently enabled in this project (see
https://cmake.org/cmake/help/latest/module/CTest.html
). Instead, we use the ADMC_BUILD_DEB variable, which is OFF by default. We need to consider one of three options: creating and setting a separate variable to explicitly enable or disable testing, setting ADMC_BUILD_DEB to ON by default, or completely refactoring the test setup.
@kvvloten please review.
The set cmake_minimum_required to 3.5 I made to fix a deprecation warning.
Now we have two ways to build a deb package: the standard
debuildand themake packageto build the deb package directly from the cmake with CPack. I found this confusing and unless the CPack is really used I would propose to remove it.UPD fixed in 468dcc8 Another problem is that tests are included by default unless the
ADMC_BUILD_DEBvar is not set. Because of this we have to specify theADMC_BUILD_DEBin thedebian/rulesfile.Maybe the test should be implemented with the CMake add_test or something like that to make it more standard. The the debhelper will just skip the tests in the convenient way.