Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritise paid developer account over free #398

Closed
wants to merge 1 commit into from
Closed

Prioritise paid developer account over free #398

wants to merge 1 commit into from

Conversation

toioski
Copy link

@toioski toioski commented Oct 25, 2020

I have opened again the #103 originally developed by @luken11 because it was pointing to master instead of develop. I hope it's gonna get merged soon because it's a killer feature!

If an account has both a free and paid developer account active concurrently, then the free account is preferred. Prefer the paid account for a longer signing period

If an account has both a free and paid developer account active concurrently, then the free account is preferred. Prefer the paid account for a longer signing period
@ghost
Copy link

ghost commented Oct 25, 2020

I would like to see this too. Hopefully later there will come an account chooser too.

@drpoutine
Copy link

drpoutine commented Oct 27, 2020

this should be merged in already. account chooser screen in next pr 🤔

ps: cant compile as the depends for altsign and roxas that it wants to pull for submodule is missing/404notfound

@ghost
Copy link

ghost commented Oct 27, 2020

@drpoutine, @rileytestut has not really been active for the past while. He sometimes makes commits, but has little to no activity in the issues and pull requests.

Copy link

@McIntosh56 McIntosh56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait!

@toioski
Copy link
Author

toioski commented Nov 2, 2020

@bensova what are we waiting in order to merge? When do you think it could be released?

@ghost
Copy link

ghost commented Nov 2, 2020

@toioski I'm not a contributor to this repo, so I have no idea about when @rileytestut will get on and merge this pull request. Right now AltStore isn't seeing too much activity from Riley.

@soberhofer
Copy link

This would be so beneficial, hope it gets merged soon!

@bamhm182
Copy link

bamhm182 commented Jan 1, 2021

Still not merged. Fingers crossed it is merged and a new version comes soon...

@bamhm182
Copy link

bamhm182 commented Jan 2, 2021

From the patreon, it looks like that feature should be coming in 1.5, but it still isn't working for me in 1.5b1.

@noah978
Copy link
Member

noah978 commented Jan 5, 2021

The commit here corrects this behavior in AltServer which is already available in the 1.5b1+ version. However, this change does not fix those with organization developer accounts (dev profiles that belong to corporations).

The correct solution here is to list all the available profiles for the provided Apple ID and let the user decide. So the final 1.5 release of AltServer will add the necessary UI for the user to choose the correct profile for them.

@joekw
Copy link

joekw commented Feb 10, 2021

The commit here corrects this behavior in AltServer which is already available in the 1.5b1+ version. However, this change does not fix those with organization developer accounts (dev profiles that belong to corporations).

The correct solution here is to list all the available profiles for the provided Apple ID and let the user decide. So the final 1.5 release of AltServer will add the necessary UI for the user to choose the correct profile for them.

Why bother putting effort into creating this feature when prioritising Organisation > Individual > Free would do the same thing? Maybe I'm just not seeing a reason why the user would need to pick.

@ghost
Copy link

ghost commented Mar 1, 2021

If you use your Apple ID for actual work and are not an indie developer, I could see why. You don't want to use your work account to sign apps. The UI picker would be best, but I'm going to try to recompile this to work with organization accounts for those who want it.

@Megarushing
Copy link

I pushed a Team selector PR now, hopefully will be the best of 2 worlds #751

@Megarushing
Copy link

If you use your Apple ID for actual work and are not an indie developer, I could see why. You don't want to use your work account to sign apps. The UI picker would be best, but I'm going to try to recompile this to work with organization accounts for those who want it.

I agree with you, I used to work on a banking app and having the profiles show up there would result in instant job loss 🙃

@lonkelle
Copy link
Member

Thanks for this @Megarushing - I really wish it was easier to support switching teams on device. We just have a lot of work to do to make that possible so if this was a PR for a team selector on AltServer, we'd merge it in a second tho. This is def one of our priorities, but we wanna get it "right" on iOS so mandating AltServer to be the Team Selector seems like the best bet rn.

Copy link

@gokulbeeshman gokulbeeshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anmol500
Copy link

Happy new year! please merge it now

@lonkelle
Copy link
Member

lonkelle commented Jan 1, 2023

@anmol500 This should already be enabled in AltStore (not AltServer as Riley didn't make that priority, tho I think he should).

The problem is that Organization paid devs don't work currently and this PR doesn't account for them. It's only a 3 line code change but, again, that's up to Riley. I could code my own PR for Org Paid Dev accounts and merge it since I'm a Project Maintainer, but I don't wanna do so without his permission and he's been silent about this kind of thing since 2021.

@lonkelle lonkelle closed this Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.