-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritise paid developer account over free #398
Prioritise paid developer account over free #398
Conversation
If an account has both a free and paid developer account active concurrently, then the free account is preferred. Prefer the paid account for a longer signing period
I would like to see this too. Hopefully later there will come an account chooser too. |
this should be merged in already. account chooser screen in next pr 🤔 ps: cant compile as the depends for altsign and roxas that it wants to pull for submodule is missing/404notfound |
@drpoutine, @rileytestut has not really been active for the past while. He sometimes makes commits, but has little to no activity in the issues and pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't wait!
@bensova what are we waiting in order to merge? When do you think it could be released? |
@toioski I'm not a contributor to this repo, so I have no idea about when @rileytestut will get on and merge this pull request. Right now AltStore isn't seeing too much activity from Riley. |
This would be so beneficial, hope it gets merged soon! |
Still not merged. Fingers crossed it is merged and a new version comes soon... |
From the patreon, it looks like that feature should be coming in 1.5, but it still isn't working for me in 1.5b1. |
The commit here corrects this behavior in AltServer which is already available in the 1.5b1+ version. However, this change does not fix those with organization developer accounts (dev profiles that belong to corporations). The correct solution here is to list all the available profiles for the provided Apple ID and let the user decide. So the final 1.5 release of AltServer will add the necessary UI for the user to choose the correct profile for them. |
Why bother putting effort into creating this feature when prioritising Organisation > Individual > Free would do the same thing? Maybe I'm just not seeing a reason why the user would need to pick. |
If you use your Apple ID for actual work and are not an indie developer, I could see why. You don't want to use your work account to sign apps. The UI picker would be best, but I'm going to try to recompile this to work with organization accounts for those who want it. |
I pushed a Team selector PR now, hopefully will be the best of 2 worlds #751 |
I agree with you, I used to work on a banking app and having the profiles show up there would result in instant job loss 🙃 |
Thanks for this @Megarushing - I really wish it was easier to support switching teams on device. We just have a lot of work to do to make that possible so if this was a PR for a team selector on AltServer, we'd merge it in a second tho. This is def one of our priorities, but we wanna get it "right" on iOS so mandating AltServer to be the Team Selector seems like the best bet rn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Happy new year! please merge it now |
@anmol500 This should already be enabled in AltStore (not AltServer as Riley didn't make that priority, tho I think he should). The problem is that Organization paid devs don't work currently and this PR doesn't account for them. It's only a 3 line code change but, again, that's up to Riley. I could code my own PR for Org Paid Dev accounts and merge it since I'm a Project Maintainer, but I don't wanna do so without his permission and he's been silent about this kind of thing since 2021. |
I have opened again the #103 originally developed by @luken11 because it was pointing to
master
instead ofdevelop
. I hope it's gonna get merged soon because it's a killer feature!If an account has both a free and paid developer account active concurrently, then the free account is preferred. Prefer the paid account for a longer signing period