Hero title #235
Closed
Hero title #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Se agrego la propiedad de CSS Text-wrap: balance - Se quitaron los saltos de línea de los SCREEN_HERO_CONTAINER.TITLE - Propiedades CSS repetidas con los mismos valores, ahora están en el Box para evitar repetición
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Mmm este es el segundo intento de hacer un pull request, en ambos casos falla en el deploy de vercel, me gustaría saber por qué. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments in the HeroTitle: We removed unnecessary line breaks (
<br>) and added thetext-wrap: balanceproperty so that the title text adjusts evenly according to the container size.Fixing overflow in Sua Carreira, Text: The width of the text “GUIE SUA CARREIRA!” was overflowing from the general title container, so we adjusted it so that it doesn’t protrude.