Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use previous commit if no GitHub before push sha #110

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

MattIPv4
Copy link
Member

No description provided.

@MattIPv4 MattIPv4 requested review from Copilot and pjeweb January 27, 2025 19:17
pjeweb
pjeweb previously approved these changes Jan 27, 2025
@MattIPv4
Copy link
Member Author

Hm, realising this should probably use base_ref, not origin/main. Let me test some more

@MattIPv4 MattIPv4 changed the title Fallback to main for version check if no before sha Use previous commit if no GitHub before push sha Jan 27, 2025
@MattIPv4
Copy link
Member Author

Tested that commit on a new branch: https://github.com/alveusgg/data/actions/runs/12996732327/job/36246134681

@MattIPv4 MattIPv4 requested a review from pjeweb January 27, 2025 19:26
@MattIPv4 MattIPv4 merged commit 6658362 into main Jan 27, 2025
15 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-version-check-on-branch branch January 27, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants