Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zod schema for ambassadors #88

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Add Zod schema for ambassadors #88

merged 8 commits into from
Dec 12, 2024

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Dec 11, 2024

In support of the work on the extension to allow it to fetch ambassador data in real-time from the website, adding schemas for the core data so that it may validate the structure of the API data.

@MattIPv4 MattIPv4 force-pushed the MattIPv4/zod-schema branch from 79e567c to d636cc1 Compare December 11, 2024 22:46
@MattIPv4 MattIPv4 changed the title Add Zod schema Add Zod schema for ambassadors Dec 12, 2024
@MattIPv4 MattIPv4 marked this pull request as ready for review December 12, 2024 03:21
@MattIPv4 MattIPv4 requested a review from Copilot December 12, 2024 03:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 suggestions.

Files not reviewed (1)
  • package.json: Language not supported
Comments skipped due to low confidence (2)

src/iucn.ts:22

  • [nitpick] The function name isIUCNStatuses is misleading. It should be renamed to isIUCNStatus.
const isIUCNStatuses = (str: string): str is IUCNStatuses =>

src/iucn.ts:25

  • [nitpick] The function name isIUCNFlags is misleading. It should be renamed to isIUCNFlag.
const isIUCNFlags = (str: string): str is ICUNFlags =>

src/ambassadors/core.ts Show resolved Hide resolved
src/ambassadors/core.ts Show resolved Hide resolved
@MattIPv4 MattIPv4 requested a review from pjeweb December 12, 2024 03:26
@MattIPv4 MattIPv4 merged commit ee2c147 into main Dec 12, 2024
6 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/zod-schema branch December 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants