Skip to content

Commit

Permalink
Try building py39 wheels to see if that helps with reinitialization e…
Browse files Browse the repository at this point in the history
…rrors (pyca#695)
  • Loading branch information
alex authored Dec 15, 2023
1 parent 5049783 commit b9223e6
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/wheel-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
matrix:
PYTHON:
- { VERSION: "cp37-cp37m", ABI_VERSION: 'cp37' }
- { VERSION: "cp39-cp39", ABI_VERSION: 'cp39' }
- { VERSION: "pp39-pypy39_pp73" }
- { VERSION: "pp310-pypy310_pp73" }
MANYLINUX:
Expand Down Expand Up @@ -130,6 +131,10 @@ jobs:
ABI_VERSION: 'cp37'
DOWNLOAD_URL: 'https://www.python.org/ftp/python/3.11.3/python-3.11.3-macos11.pkg'
BIN_PATH: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3'
- VERSION: '3.11'
ABI_VERSION: 'cp39'
DOWNLOAD_URL: 'https://www.python.org/ftp/python/3.11.3/python-3.11.3-macos11.pkg'
BIN_PATH: '/Library/Frameworks/Python.framework/Versions/3.11/bin/python3'
name: "Python ${{ matrix.PYTHON.VERSION }} for ABI ${{ matrix.PYTHON.ABI_VERSION }} on macOS"
steps:
- run: |
Expand Down Expand Up @@ -179,6 +184,7 @@ jobs:
- {ARCH: 'x64', RUST_TRIPLE: 'x86_64-pc-windows-msvc'}
PYTHON:
- {VERSION: "3.11", ABI_VERSION: "cp37"}
- {VERSION: "3.11", ABI_VERSION: "cp39"}
name: "${{ matrix.PYTHON.VERSION }} ${{ matrix.PYTHON.ABI_VERSION }} ${{ matrix.WINDOWS.ARCH }}"
steps:
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
Expand Down
6 changes: 6 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ While bcrypt remains an acceptable choice for password storage, depending on you
Changelog
=========

4.1.2
-----

* Publish both ``py37`` and ``py39`` wheels. This should resolve some errors
relating to initializing a module multiple times per process.

4.1.1
-----

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ build-backend = "setuptools.build_meta"
[project]
name = "bcrypt"
# When updating this, also update lib.rs
version = "4.1.1"
version = "4.1.2"
authors = [
{name = "The Python Cryptographic Authority developers", email = "[email protected]"}
]
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
RustExtension(
"bcrypt._bcrypt",
"src/_bcrypt/Cargo.toml",
py_limited_api=True,
py_limited_api="auto",
rust_version=(
">=1.64.0"
if os.environ.get("BCRYPT_ALLOW_RUST_163", "0") != "0"
Expand Down
2 changes: 1 addition & 1 deletion src/_bcrypt/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ edition = "2018"
publish = false

[dependencies]
pyo3 = { version = "0.20.0", features = ["abi3-py37"] }
pyo3 = { version = "0.20.0", features = ["abi3"] }
bcrypt = "0.15"
bcrypt-pbkdf = "0.10.0"
base64 = "0.21.5"
Expand Down
2 changes: 1 addition & 1 deletion src/_bcrypt/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ fn _bcrypt(_py: pyo3::Python<'_>, m: &pyo3::types::PyModule) -> pyo3::PyResult<(
// When updating this, also update pyproject.toml
// This isn't named __version__ because passlib treats the existence of
// that attribute as proof that we're a different module
m.add("__version_ex__", "4.1.1")?;
m.add("__version_ex__", "4.1.2")?;

let author = "The Python Cryptographic Authority developers";
m.add("__author__", author)?;
Expand Down

0 comments on commit b9223e6

Please sign in to comment.