Skip to content

Tracking rewrite

Tracking rewrite #4409

GitHub Actions / clippy succeeded Oct 28, 2024 in 0s

clippy

31 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 31
Note 0
Help 0

Versions

  • rustc 1.82.0 (f6e511eec 2024-10-15)
  • cargo 1.82.0 (8f40fc59f 2024-08-21)
  • clippy 0.1.82 (f6e511ee 2024-10-15)

Annotations

Check warning on line 8 in alvr/dashboard/src/dashboard/components/settings_controls/notice.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `notice` is never used

warning: function `notice` is never used
 --> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8
  |
8 | pub fn notice(ui: &mut Ui, text: &str) {
  |        ^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

Check warning on line 437 in alvr/client_openxr/src/interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr/client_openxr/src/interaction.rs:437:13
    |
437 |             &reference_space,
    |             ^^^^^^^^^^^^^^^^ help: change this to: `reference_space`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 423 in alvr/client_openxr/src/interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> alvr/client_openxr/src/interaction.rs:423:17
    |
423 |         .relate(&reference_space, time)
    |                 ^^^^^^^^^^^^^^^^ help: change this to: `reference_space`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 28 in alvr/client_openxr/src/interaction.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `aim_action` and `aim_space` are never read

warning: fields `aim_action` and `aim_space` are never read
  --> alvr/client_openxr/src/interaction.rs:28:9
   |
24 | pub struct HandInteraction {
   |            --------------- fields in this struct
...
28 |     pub aim_action: xr::Action<xr::Posef>,
   |         ^^^^^^^^^^
29 |     pub aim_space: xr::Space,
   |         ^^^^^^^^^

Check warning on line 90 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `system` is never read

warning: field `system` is never read
  --> alvr/client_openxr/src/lib.rs:90:5
   |
88 | pub struct XrContext {
   |            --------- field in this struct
89 |     instance: xr::Instance,
90 |     system: xr::SystemId,
   |     ^^^^^^
   |
   = note: `XrContext` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 193 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr/client_openxr/src/lib.rs:193:9
    |
193 |     let mut parsed_stream_config = None::<ParsedStreamConfig>;
    |         ----^^^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`

Check warning on line 192 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> alvr/client_openxr/src/lib.rs:192:9
    |
192 |     let mut last_lobby_message = String::new();
    |         ----^^^^^^^^^^^^^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 205 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_stream`

warning: unused variable: `xr_frame_stream`
   --> alvr/client_openxr/src/lib.rs:205:51
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                                                   ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

Check warning on line 205 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_frame_waiter`

warning: unused variable: `xr_frame_waiter`
   --> alvr/client_openxr/src/lib.rs:205:30
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |                              ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

Check warning on line 205 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `xr_session`

warning: unused variable: `xr_session`
   --> alvr/client_openxr/src/lib.rs:205:14
    |
205 |         let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe {
    |              ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

Check warning on line 193 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `parsed_stream_config`

warning: unused variable: `parsed_stream_config`
   --> alvr/client_openxr/src/lib.rs:193:13
    |
193 |     let mut parsed_stream_config = None::<ParsedStreamConfig>;
    |             ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_parsed_stream_config`

Check warning on line 192 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `last_lobby_message`

warning: unused variable: `last_lobby_message`
   --> alvr/client_openxr/src/lib.rs:192:13
    |
192 |     let mut last_lobby_message = String::new();
    |             ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 211 in alvr/client_openxr/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable definition

warning: unreachable definition
   --> alvr/client_openxr/src/lib.rs:211:13
    |
207 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ------------------------------------------------ any code following this expression is unreachable
...
211 |         let xr_context = XrContext {
    |             ^^^^^^^^^^ unreachable definition
    |
note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited
   --> alvr/client_openxr/src/lib.rs:207:45
    |
207 |                 .create_session(xr_system, &graphics::session_create_info(&graphics_context))
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: `#[warn(unreachable_code)]` on by default

Check warning on line 564 in alvr/server_core/src/tracking/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `.filter_map` can be written more simply using `.map`

warning: this `.filter_map` can be written more simply using `.map`
   --> alvr/server_core/src/tracking/mod.rs:555:38
    |
555 |                   let device_motions = device_motion_keys
    |  ______________________________________^
556 | |                     .iter()
557 | |                     .filter_map(move |id| {
558 | |                         Some((
...   |
563 | |                         ))
564 | |                     })
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map

Check warning on line 535 in alvr/server_core/src/tracking/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `.filter_map` can be written more simply using `.map`

warning: this `.filter_map` can be written more simply using `.map`
   --> alvr/server_core/src/tracking/mod.rs:526:38
    |
526 |                   let device_motions = device_motion_keys
    |  ______________________________________^
527 | |                     .iter()
528 | |                     .filter_map(move |id| {
529 | |                         Some((
...   |
534 | |                         ))
535 | |                     })
    | |______________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
    = note: `#[warn(clippy::unnecessary_filter_map)]` on by default

Check warning on line 67 in alvr/server_core/src/tracking/vmc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

float has excessive precision

warning: float has excessive precision
  --> alvr/server_core/src/tracking/vmc.rs:67:48
   |
67 |             Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000),
   |                                                ^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
help: consider changing the type or truncating it to
   |
67 |             Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000),
   |                                                ~~~~~~~~

Check warning on line 59 in alvr/server_core/src/tracking/vmc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

float has excessive precision

warning: float has excessive precision
  --> alvr/server_core/src/tracking/vmc.rs:59:58
   |
59 |             Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100),
   |                                                          ^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
   = note: `#[warn(clippy::excessive_precision)]` on by default
help: consider changing the type or truncating it to
   |
59 |             Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11),
   |                                                          ~~~~~~~~

Check warning on line 133 in alvr/server_core/src/bitrate.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`f32` -> `f32`)

warning: casting to the same type is unnecessary (`f32` -> `f32`)
   --> alvr/server_core/src/bitrate.rs:133:25
    |
133 |                         self.packet_bytes_average.get_average() as f32,
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 158 in alvr/client_mock/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `ViewParams` which implements the `Copy` trait

warning: using `clone` on type `ViewParams` which implements the `Copy` trait
   --> alvr/client_mock/src/main.rs:158:31
    |
158 |     context.send_view_params([views_params.clone(), views_params]);
    |                               ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 307 in alvr/server_core/src/statistics.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `tracker_pose_time_offset` is never used

warning: method `tracker_pose_time_offset` is never used
   --> alvr/server_core/src/statistics.rs:307:12
    |
63  | impl StatisticsManager {
    | ---------------------- method in this implementation
...
307 |     pub fn tracker_pose_time_offset(&self) -> Duration {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 56 in alvr/server_core/src/statistics.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `steamvr_pipeline_latency` is never read

warning: field `steamvr_pipeline_latency` is never read
  --> alvr/server_core/src/statistics.rs:56:5
   |
43 | pub struct StatisticsManager {
   |            ----------------- field in this struct
...
56 |     steamvr_pipeline_latency: Duration,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 672 in alvr/server_core/src/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> alvr/server_core/src/connection.rs:672:13
    |
672 |             enable_hdr: enable_hdr,
    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enable_hdr`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 671 in alvr/server_core/src/connection.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> alvr/server_core/src/connection.rs:671:13
    |
671 |             encoding_gamma: encoding_gamma,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding_gamma`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `#[warn(clippy::redundant_field_names)]` on by default

Check warning on line 374 in alvr/client_core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
   --> alvr/client_core/src/lib.rs:374:9
    |
363 | /         let view_params = [
364 | |             ViewParams {
365 | |                 pose: head_pose * view_params[0].pose,
366 | |                 fov: view_params[0].fov,
...   |
371 | |             },
372 | |         ];
    | |__________- unnecessary `let` binding
373 |
374 |           view_params
    |           ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
    = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
    |
363 ~         
364 |
365 ~         [
366 +             ViewParams {
367 +                 pose: head_pose * view_params[0].pose,
368 +                 fov: view_params[0].fov,
369 +             },
370 +             ViewParams {
371 +                 pose: head_pose * view_params[1].pose,
372 +                 fov: view_params[1].fov,
373 +             },
374 +         ]
    |

Check warning on line 322 in alvr/client_core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> alvr/client_core/src/lib.rs:322:19
    |
322 |         callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>,
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity