Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threading through of logger #505

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

edoardopirovano
Copy link
Contributor

Further follow-up to #499

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
report-diffs-action ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 5:03pm

Copy link

alwaysmeticulous bot commented Sep 4, 2024

🤖 Meticulous replayed 1 user sessions and took 8 visual snapshots. There were no comparisons made.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Test suite: public-tests. Last updated for commit a40573f. This comment will update as new commits are pushed.

@edoardopirovano edoardopirovano merged commit f263cb0 into main Sep 4, 2024
10 checks passed
@edoardopirovano edoardopirovano deleted the edoardo/thread-more branch September 4, 2024 17:06
Copy link

github-actions bot commented Sep 4, 2024

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with app url. Last updated for commit a40573f. This comment will update as new commits are pushed.

Copy link

github-actions bot commented Sep 4, 2024

🤖 Meticulous replayed 1 user sessions and took 8 visual snapshots. Meticulous did not run on null of the main branch and so there was nothing to compare against.

Please merge your pull request for setting up Meticulous in CI and ensure that it’s running on push events to the main branch.

Test suite: test Meticulous with deployment url. Last updated for commit a40573f. This comment will update as new commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant