Merge pull request #257 from Sprokof/params-accept-array-string

Params accept array string
amadeus4dev · Mar 8, 2024 · e6c611d · e6c611d
2 parents 68a3c58 + f49c3bf
commit e6c611d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/main/java/com/amadeus/Params.java b/src/main/java/com/amadeus/Params.java
@@ -3,6 +3,7 @@
 import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -48,7 +49,12 @@ public static Params with(@NonNull String key, Object value) {
    * @return the Param object, allowing for convenient chaining
    */
   public Params and(@NonNull String key, Object value) {
-    put(key, String.valueOf(value));
+    if (value instanceof List) {
+      @SuppressWarnings("unchecked") List<String> values = (List<String>) value;
+      put(key, String.join(",", values));
+    } else {
+      put(key, String.valueOf(value));
+    }
     return this;
   }
 

diff --git a/src/test/java/com/amadeus/ParamsTest.java b/src/test/java/com/amadeus/ParamsTest.java
@@ -3,6 +3,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
+import java.util.Arrays;
 import org.junit.jupiter.api.Test;
 
 public class ParamsTest {
@@ -22,6 +23,11 @@ public class ParamsTest {
     assertEquals(params.toQueryString(), "bar=234&foo=123");
   }
 
+  @Test public void testToQueryStringWithList() {
+    Params params = Params.with("foo", Arrays.asList("id1", "id2"));
+    assertEquals(params.toQueryString(), "foo=id1%2Cid2");
+  }
+
   @Test public void testToQueryStringWithEncodingError() {
     Params params = Params.with("foo", "123");
     params.encoding = "foobar";