Filecreate feature final version (support yaml file and spec list) and documentation #7
Conversation
| # Check yaml file | ||
| if [[ $Opt_YAML -ne 0 ]]; then | ||
| echo conda env create -q "${CONDA_ARGS[@]}" python="${PY}" "${CONDA_XTRA[@]}" | ||
| conda env create -q "${CONDA_ARGS[@]}" python="${PY}" "${CONDA_XTRA[@]}" |
There was a problem hiding this comment.
Do we need to specify the Python version when using --file? Won't the environment file have python in the list? What happens if it doesn't?
There was a problem hiding this comment.
I LITERALLY had the same lines highlighted and started to write the same thing last night :)
I too was contemplating dropping the python="${PY}" for the case of --file... no firm opinion except that sometimes it can help to make sure that environment name matches the actual content (when python is not listed in the YAML).
But at the same time the big concern is that it may override what's in the YAML (so suddenly the resulting environment would be clandestinely different from what the researcher expected, which is bad for reproducibility).
Won't the environment file have python in the list? What happens if it doesn't?
An equally interesting question is also what happens if it does? Which version wins - the $PY one or the one inside the YAML? Are command-line packages even considered when --file is in effect?
Sounds like an experiment to be had :)
| Python version in YAML | No Python version in YAML | |
|---|---|---|
| With python=${PY} | ||
| Without python=${PY} |
No description provided.