Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-router-dom, Fix GitHub Pages Issue, and Introduce About Us and Contact Us Pages #21

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

saurabhbakolia
Copy link
Contributor

@saurabhbakolia saurabhbakolia commented Oct 5, 2023

In this pull request, I've introduced the react-router-dom ( issue #11 ) library to enable smooth navigation within the application . Additionally, I've resolved the 'githubpages-issue' for enhanced functionality (issue #16 ).

Furthermore, I've implemented two new pages – 'About Us' and 'Contact Us'

  • To provide users with more information and a means of getting in touch. These additions enhance the user experience and improve the overall functionality of the application.

I look forward to your feedback and collaboration on these changes. Thank you!"

@welcome
Copy link

welcome bot commented Oct 5, 2023

💖Thanks for opening this pull request! Please check out our contributing guidelines.💖

@saurabhbakolia saurabhbakolia changed the title Issue number #16 and #11 fixed "Add react-router-dom, Fix GitHub Pages Issue, and Introduce About Us and Contact Us Pages" Oct 5, 2023
@saurabhbakolia saurabhbakolia changed the title "Add react-router-dom, Fix GitHub Pages Issue, and Introduce About Us and Contact Us Pages" Add react-router-dom, Fix GitHub Pages Issue, and Introduce About Us and Contact Us Pages Oct 5, 2023
@amanrajrana
Copy link
Owner

@saurabhbakolia This PR has conflicts. We already Introduce react-router in PR #20

@saurabhbakolia
Copy link
Contributor Author

@amanrajrana Now, issues are resolved, Please check it out.

@amanrajrana
Copy link
Owner

LGTM

@amanrajrana amanrajrana merged commit 45642fb into amanrajrana:main Oct 6, 2023
1 check passed
@welcome
Copy link

welcome bot commented Oct 6, 2023

🎉 Congratulations! 🎉
Your pull request has been approved and is now merged into the project! 🚀 Thank you for your valuable contribution to our open-source community.

Your dedication and hard work have made our project even better. We truly appreciate your effort in helping us improve and grow.

If you have any more ideas, suggestions, or contributions in the future, please don't hesitate to reach out. We welcome your continued involvement in our project.

Once again, thank you for your commitment and for making a positive impact on our open-source journey. 🙌

Cheers,
RobustKey Team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants