-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate alias file #15
Open
bomoko
wants to merge
14
commits into
master
Choose a base branch
from
feature/generate_alias_file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9543cb7
Adds generate alias file command
bomoko 0a16652
Adds some debugging and file output option
bomoko 1a12df8
Fixing phpcs errors
bomoko 0cce42b
fixes phpcs errors and changes references in graphql
bomoko e92abec
Fixing phpcs issues
bomoko b7f413d
phpcs errors
bomoko b5ffe77
Merge branch 'main' into feature/generate_alias_file
tobybellwood 277c4b9
use kubernetesNamespaceName for la returns too
tobybellwood fb9bfd0
Adds fallbacks for lagoon alias file generation
bomoko 1e310ed
Merge branch 'feature/generate_alias_file' of github.com:amazeeio/dru…
bomoko fa5cf9c
Makes tty a bool
bomoko 47a1dfc
Adds env for config api host
bomoko b5ce1f2
Fixes correct operator
bomoko 4997d43
Uses fully qualified name for env name
bomoko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to handle existing deploytargets here that have no specific ssh host set - otherwise they will return
null
as the host?I'm just not sure where to read it from - we could fall back to the lagoon aliases (or a hard coded default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobybellwood - I think that should do it.