-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed D-wave examples breaking when the Advantage_System4 is in a maintenance window #143
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cell 3 of Dwave_Anatomy.ipynb can you make the behavior of the cell graceful even in cases where no Advantage device is online?
In the same notebook the Cell 27 and onwards is broken, can you fix?
Yes @christianbmadsen I'll fix that. |
39b4554
to
67a59bf
Compare
67a59bf
to
50bb8e6
Compare
@JuanGiraldo0212 were you able to take a look at the edge cases for online devices. For instance what do you want the behavior of cell 8 of Getting_Devices_and_Checking_Device_Properties.ipynb to be if no devices are ONLINE? Thanks! |
Hi @christianbmadsen, yes I used this logic in the case no Advantage devices are ONLINE: device_arns = [device.arn for device in AwsDevice.get_devices(provider_names=["D-Wave Systems"], statuses=["ONLINE"])] I used it in cell 47 of Dwave_Anatomy, let me know if this is a good fix and I will add it to the rest of the notebooks where an Advantage device is needed. |
@JuanGiraldo0212 I recommend we only try the intended advatage device and then handle the exception and avoid executing the remainder of the example if no advantage device is available. |
@JuanGiraldo0212 just wanted to checkin and see how you were planning to handle this? |
Hi @christianbmadsen, sorry I haven't had chance to finish the issue. I was planning on checking if there is an advantage device available and in the case that there aren't any I would display a message asking to wait until the requested device is online to continue the example. |
Issue #117: D-Wave examples break during scheduled maintenance windows
Description of changes:
Added branching logic to find the first Advantage device available to these files:
Removed the device ARN when instantiating a D-wave sampler to these files:
Removed unnecessary cells.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.