Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hamiltonian Simulation #179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tichrisl137
Copy link

@tichrisl137 tichrisl137 commented Aug 11, 2022

This models the time evolution of a quantum system using the Trotterization method on the local simulator.

@tichrisl137 tichrisl137 requested a review from a team as a code owner August 11, 2022 20:39
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tichrisl137
Copy link
Author

This should be pretty much ready as a first draft.

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ajberdy commented on 2022-08-22T20:17:30Z
----------------------------------------------------------------

I think the style could benefit from some whitespace around commas, operators to be more consistent with our other code


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ajberdy commented on 2022-08-22T20:17:31Z
----------------------------------------------------------------

Line #2.    #First we define the number of qubits we are going to use.

Typically, a space is used after the # in comments


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ajberdy commented on 2022-08-22T20:17:32Z
----------------------------------------------------------------

We will need to add a commit to the render-pngs branch to handle a bug with inline images


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ajberdy commented on 2022-08-22T20:17:33Z
----------------------------------------------------------------

*state vector result type


@review-notebook-app
Copy link

review-notebook-app bot commented Aug 22, 2022

View / edit / reply to this conversation on ReviewNB

ajberdy commented on 2022-08-22T20:17:35Z
----------------------------------------------------------------

Do we need all of this precision?


tichrisl137 commented on 2022-09-14T01:26:35Z
----------------------------------------------------------------

This is just to show that the result converges with the actual result. If you want, I can tell the user that they can use less precision.

Copy link
Author

This is just to show that the result converges with the actual result. If you want, I can tell the user that they can use less precision.


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant