Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add U and GPhase gates #799
feat: add U and GPhase gates #799
Changes from 1 commit
d784d88
9633a2a
e68e78c
0c2c9e8
c3044cb
d6d6886
388367c
7a52eb8
d8917f3
f35cc38
fa4cb3a
5ddf96e
3c0d766
9f8a547
76989f7
f1204d0
f5d0511
f68b084
5c56724
70844ee
dabb790
31a60f8
0b02f14
0a7985e
c75f331
df1b1a9
daa9cd9
9e5f7dc
aa46064
590d9c8
dec59aa
ef91d3d
dfdecfe
e5eaa21
b8f0f33
244d708
c185e41
4efb8bc
ccb81fa
4aa7545
c2291f8
9386bca
ecbdff1
696974d
ad1053f
cb6baac
52ce20d
d61a0d1
b14c03b
095fb68
8ebb0ce
35a92cd
0626370
304a01d
b6e9563
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add defaults for this gate as we did with MS? That way we can users can define a u2 gate by only providing relevant params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be tricky since only the first gate would have a default, so maybe we circle back to this in another pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just add documentation that setting angle_1 to pi/2 is equivalent to U2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like u2/u3 are defined with a combination of gphase and U here. I like the idea to define u_i / update the docstring in another PR.