Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated atom_arrangement.py #985

Closed
wants to merge 1 commit into from

Conversation

AbdullahKazi500
Copy link

Issue #, if available:
fixes #969
Description of changes:
defined the SiteType enum and AtomArrangementItem dataclass to handle the coordinates and site types, ensuring validations.
AtomArrangement Class:
The class initializes with an empty list of sites.
Add Method: Adds a coordinate to the arrangement with a site type.
Retrieves a list of coordinates for a given index.
Rounds coordinates to the nearest multiple of the given resolution.
Factory Methods: Methods for creating square and rectangular lattice arrangements. Demonstrates creating a square lattice with specified boundary points and lattice constant.
Testing done:
will be adding the test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

 defined the SiteType enum and AtomArrangementItem dataclass to handle the coordinates and site types, ensuring validations.
AtomArrangement Class:
 The class initializes with an empty list of sites.
Add Method: Adds a coordinate to the arrangement with a site type.
 Retrieves a list of coordinates for a given index.
 Rounds coordinates to the nearest multiple of the given resolution.
Factory Methods: Methods for creating square and rectangular lattice arrangements.
Demonstrates creating a square lattice with specified boundary points and lattice constant.
@peterkomar-aws
Copy link
Contributor

Please consolidate the work to this PR: #989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factory methods for AHS AtomArrangments
2 participants