Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add automated benchmarking to GitHub #35

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Split off the benchmarking logic from unrelated stuff in previous PR

Testing done: Worked locally with act but needs live test on GH to make sure

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner August 27, 2024 19:33
rmshaffer
rmshaffer previously approved these changes Aug 27, 2024
@kshyatt-aws
Copy link
Member Author

Looks like we need a gh-pages branch no matter what, perhaps we can create an orphan branch for that? Or host our Sphinx docs there?

Base automatically changed from ksh/speed to ksh/nobraket August 27, 2024 20:37
Base automatically changed from ksh/nobraket to main August 28, 2024 17:42
@kshyatt-aws kshyatt-aws dismissed rmshaffer’s stale review August 28, 2024 17:42

The base branch was changed.

rmshaffer
rmshaffer previously approved these changes Aug 30, 2024
rmshaffer
rmshaffer previously approved these changes Sep 24, 2024
rmshaffer
rmshaffer previously approved these changes Oct 7, 2024
@kshyatt-aws kshyatt-aws merged commit c5e9bcd into main Oct 7, 2024
14 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/benchmark branch October 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants