Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume aws-sdk@2 from npm; remove baked in file; closes #2 #200

Closed
wants to merge 1 commit into from

Conversation

spencerlepine
Copy link
Contributor

@spencerlepine spencerlepine commented Nov 3, 2023

Issue #, if available:

Description of changes:

consume aws-sdk@2 from npm; remove baked in file aws-sdk-connectparticipant.js

// also imports global 'AWS'
import ConnectParticipant from "aws-sdk/clients/connectparticipant"; // AWS SDK v2

this.chatClient = new ConnectParticipant({
      credentials: new AWS.Credentials('',''),
      endpoint: args.endpoint,
      region: args.region
});

NOTE

May need to upgrade to AWS SDK v3 instead. v2 may have conflict with AWS global configuration, but V3 does not have this issue (see README and Streams import notes)

const { ConnectParticipantClient } = require("@aws-sdk/client-connectparticipant"); // AWS SDK v3

const client = new ConnectParticipantClient({ region: "region" });

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@spencerlepine spencerlepine added the ✨ Enhancement Non-essential updates label Nov 3, 2023
@spencerlepine spencerlepine requested a review from a team as a code owner November 3, 2023 21:02
@spencerlepine spencerlepine requested review from mliao95 and mhiaror and removed request for a team November 3, 2023 21:02
@spenlep-amzn spenlep-amzn changed the title consume aws-sdk@2 from npm; remove baked in file consume aws-sdk@2 from npm; remove baked in file; addresses #2 Nov 14, 2023
@spenlep-amzn spenlep-amzn changed the title consume aws-sdk@2 from npm; remove baked in file; addresses #2 consume aws-sdk@2 from npm; remove baked in file; closes #2 Nov 14, 2023
@spenlep-amzn spenlep-amzn marked this pull request as draft November 14, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Non-essential updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants