cloudscape ccp in initApp fix and disabling request-storage-access (#887

) * Fixing initApp bug due to hasAnySearchParameter * Disable RSA by default Co-authored-by: Andy Wang <[email protected]>
amazon-connect · Jun 11, 2024 · 8cfe111 · 8cfe111
1 parent 8e20f4f
commit 8cfe111
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "amazon-connect-streams",
-  "version": "2.14.2",
+  "version": "2.14.3",
   "description": "Amazon Connect Streams Library",
   "engines": {
     "node": ">=12.0.0"

diff --git a/release/connect-streams-dr-min.js b/release/connect-streams-dr-min.js
diff --git a/release/connect-streams-dr.js b/release/connect-streams-dr.js
diff --git a/release/connect-streams-min.js b/release/connect-streams-min.js
diff --git a/release/connect-streams.js b/release/connect-streams.js
@@ -149,7 +149,7 @@
     connect.core.initCCP(container, ccpParams);
   };
 
-  hasAnySearchParameter = function (url) {
+  var hasAnySearchParameter = function (url) {
     var regex = /[?&]?[^=?&]+=[^=?&]+/g;
     return regex.test(url);
   }
@@ -26896,7 +26896,7 @@ AWS.apiLoader.services['connect']['2017-02-15'] = require('../apis/connect-2017-
 
   connect.core = {};
   connect.core.initialized = false;
-  connect.version = "2.14.2";
+  connect.version = "2.14.3";
   connect.outerContextStreamsVersion = null;
   connect.DEFAULT_BATCH_SIZE = 500;
 
@@ -31174,7 +31174,7 @@ AWS.apiLoader.services['connect']['2017-02-15'] = require('../apis/connect-2017-
    */
   const defaultStorageAccessParams = {
     /* Config which controls the opt out/in - we expect customers to explicitely opt out. */
-    canRequest: true,
+    canRequest: false,
     /* ["custom", "default"] - decides the rsa page view */
     mode: 'default',
     custom: {

diff --git a/src/agent-app/agent-app.js b/src/agent-app/agent-app.js
@@ -143,7 +143,7 @@
     connect.core.initCCP(container, ccpParams);
   };
 
-  hasAnySearchParameter = function (url) {
+  var hasAnySearchParameter = function (url) {
     var regex = /[?&]?[^=?&]+=[^=?&]+/g;
     return regex.test(url);
   }

diff --git a/src/request-storage-access.js b/src/request-storage-access.js
@@ -37,7 +37,7 @@
    */
   const defaultStorageAccessParams = {
     /* Config which controls the opt out/in - we expect customers to explicitely opt out. */
-    canRequest: true,
+    canRequest: false,
     /* ["custom", "default"] - decides the rsa page view */
     mode: 'default',
     custom: {

diff --git a/test/unit/request-storage-access.spec.js b/test/unit/request-storage-access.spec.js
@@ -14,7 +14,6 @@ describe('Request Storage Access module', () => {
 
   before(() => {
     sandbox = sinon.createSandbox();
-    connect.storageAccess.optInForRequestAccess();
   });
 
   beforeEach(() => {
@@ -54,9 +53,9 @@ describe('Request Storage Access module', () => {
       assert.throws(() => connect.storageAccess.init(ccpUrl), connect.ValueError, 'container must be provided');
     });
 
-    it('Should return canRequest true with no additional settings from customers and they will be opted in by default', () => {
+    it('Should return canRequest false with no additional settings from customers and they will be opted out by default', () => {
       connect.storageAccess.init(ccpUrl, container);
-      expect(connect.storageAccess.canRequest()).to.be.true;
+      expect(connect.storageAccess.canRequest()).to.be.false;
     });
 
     it('Should return canRequest false with explicit customer opt out', () => {
@@ -178,6 +177,10 @@ describe('Request Storage Access module', () => {
   describe('Request method', () => {
     let onGrantSpy;
 
+    before(() => {
+      connect.storageAccess.optInForRequestAccess();
+    });
+
     beforeEach(() => {
       onGrantSpy = sandbox.spy();
       createCcpIframeStub();