Merge new-model-changes feature branch to main #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds `Display` for `FullyQualifiedTypeReference` (For Java templates) * adds `TryFrom<serde_json::Value>` for `FullyQualifiedTypeReference` (Used ijn templates) * adds utilities for model changes * adds a `data_model_store` which stores all the data model nodes based on their `FullyQualifiedTypeReference` * adds changes for using the new `DataModelNode` * Adds `From` impls for builder errors to be converted to `CodeGenError` * Modifies test cases for TODOs and removes Rust support * Adds template changes for `Struct`
* Adds changes for Rust templates * Add `string_representation` on `FullyQualifiedTypeReference` which will have namespace represented based on programming language * Add tests for Rust code generation
* adds changes for enum support * adds tests for enum generation * Adds changes for placeholder Rust enum template * Fixes bug for Rust namespace in generated code
…pes in Sequence and Scalar ADT (#163) * Modified generator to fix bug for nested sequence namespace * Modified `fully_qualified_type_ref` method to return `FullyQualifiedTypeReference` Previously this returned `Option<FullyQualifiedTypeReference>` * Modified templates for nested types in sequence * Adds tests for nested enums * Adds changes for using enum in namespace * Adds `NamespaceNode` for `FullyQualifiedName`
* Modifies `generate_code_for_authorities` to traverse through all subdirectories of a schema authority to generate code * Modifies `generate` to generate code for header and inline imports * Adds a change for scalar template * Adds tests for inline and header imports * Remove `--schema` option
desaikd
commented
Nov 1, 2024
| use convert_case::{Case, Casing}; | ||
| use ion_rs::Value; |
There was a problem hiding this comment.
(🗺️ PR tour) This was changed due to dependency change for ion-schema-rust which removed reexport of ion-rs.
desaikd
commented
Nov 1, 2024
| } | ||
|
|
||
| fn generate_abstract_data_type( | ||
| &mut self, | ||
| isl_type_name: &str, | ||
| isl_type_name: &String, |
There was a problem hiding this comment.
(🗺️ PR tour) This was changed due to merge where newly introduced method convert_isl_type_def_to_data_model_node started using &String
popematt
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR works on merging the
new-model-changesfeature branch to main.List of changes:
Added PR tour for two merge changes, all the commits have a corresponding PR attached to it and already reviewed.
Structure#138By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.