Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider supporting $0 #95

Open
popematt opened this issue Jun 27, 2024 · 1 comment
Open

Consider supporting $0 #95

popematt opened this issue Jun 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@popematt
Copy link
Contributor

While not very common, $0 is a valid Ion symbol, but attempting to read anything containing $0 into IonElement will result in an exception being thrown.

We should consider adding support for it, if possible. Right now, SymbolElement has a non-nullable textValue: String field. Making this field nullable would be a breaking change.
@popematt popematt added the enhancement New feature or request label Jun 27, 2024
@popematt popematt mentioned this issue Jun 27, 2024
Merged
@popematt
Copy link
Contributor Author

As a partial improvement, we could make $0 a latent error that gets thrown only when trying to access some symbol that has unknown text rather than throwing eagerly on load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@popematt