Adds runner for Ion conformance tests #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ion-11-encoding #887 +/- ##
==================================================
Coverage ? 69.06%
Complexity ? 6326
==================================================
Files ? 183
Lines ? 25310
Branches ? 4528
==================================================
Hits ? 17481
Misses ? 6456
Partials ? 1373 ☔ View full report in Codecov by Sentry. |
tgregg
approved these changes
Jun 26, 2024
src/test/java/com/amazon/ion/conformance/ConformanceTestRunner.kt
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/ion/conformance/ConformanceTestRunner.kt
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/ion/conformance/ConformanceTestRunner.kt
Outdated
Show resolved
Hide resolved
| IonType.FLOAT -> recordEvent(value = doubleValue()) | ||
| IonType.DECIMAL -> recordEvent(value = decimalValue()) | ||
| IonType.TIMESTAMP -> recordEvent(value = timestampValue()) | ||
| IonType.SYMBOL -> recordEvent(value = symbolValue()) |
There was a problem hiding this comment.
Note: there are sometimes multiple APIs that can be used to retrieve values of a particular type, e.g. symbolValue() and stringValue() for IonType.SYMBOL. We should consider how to eventually add support for testing a wider variety of API combinations.
tgregg
approved these changes
Jun 28, 2024
tgregg
pushed a commit
that referenced
this pull request
Jun 28, 2024
tgregg
pushed a commit
that referenced
this pull request
Sep 9, 2024
tgregg
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#748
Description of changes:
FakeSymbolTokenimplement_Private_SymbolTokenso that we can be sure thatFakeSymbolTokenwill work everywhere we need it to._Private_IonTextWriterBuilder_1_1By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.