Use Gradle 8.6, Kotlin build script, and conventional gradle layout #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
reviewed
Apr 25, 2024
Comment on lines
+31
to
+32
| api("com.amazon.ion:ion-java:[1.4.0,)") | ||
| compileOnly("com.amazon.ion:ion-java:1.4.0") |
There was a problem hiding this comment.
Should these minimum requirements be raised given some of the fixes we've recently made in ion-java?
There was a problem hiding this comment.
I don't know. Ion Element only uses the reader/writer APIs. In general, I think it's okay to allow users of ion-element-kotlin to choose any compatible version of ion-java.
We will probably need to revisit this once Ion 1.1 is done since there will probably be new APIs in ion-java that ion-element-kotlin should leverage.
tgregg
approved these changes
Apr 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
src/main/kotlin,src/test/kotlin,src/test/java).The changes that actually need attention in the review are much smaller than it might seem.
build.gradle.kts(new).editorconfig(modified)build.gradle(deleted)src/ortest/were moved without changing any content..gitattributes,gradlew,gradlew.bat, everything ingradle/) were generated by runninggradle initto set up the project using Gradle 8.6 with Kotlin script.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.