Bumps ion-js peer- and dev-dependency to 5.2.0. #62
Conversation
package.json
Outdated
| "jsbi": "3.1.1", | ||
| "typedoc": "^0.17.3", | ||
| "ion-js": "^5.2.0", | ||
| "jsbi": "^4.3.0", |
There was a problem hiding this comment.
Is JSBI even required—can we just remove it from the dependencies completely?
There was a problem hiding this comment.
Yes, we can remove it from the dependencies. There are build errors caused by incompatible dependency versions and I'm looking into it.
linlin-s
force-pushed
the
ion-js-5.2.0
branch
from
1b64083 to
c215e5c
Compare
linlin-s
force-pushed
the
ion-js-5.2.0
branch
from
f123d1e to
0ce7f19
Compare
| // TODO: Temporarily skipping the type checking of all declaration files in the node_modules directory. More investigations required to resolve the compiling error when setting this option as false | ||
| "skipLibCheck": true |
There was a problem hiding this comment.
This gives me pause--I'd like to better understand what we're skipping by doing this. Are downstream users of our library impacted by this?
There was a problem hiding this comment.
When skipLibCheck is set to true, it enables TypeScript to bypass type checking for declaration files. We've encountered a scenario where setting this option to false results in type inconsistency errors originating from the intern dependency. We have updated this dependency to its latest version and found no related issues in its repository. Since this inconsistency stems from the third-party dependency's type declarations, in my opinion, this configuration should not affect our downstream customers.
There was a problem hiding this comment.
Created this issue #63 as a reference point to help identify the root cause in case any typechecking-related issues arise in the future.
Issue #, if available:
#61
Description of changes:
Bumps
ion-jspeer- and dev-dependency to 5.2.0. Upgradejsbiandtypedocversion to resolve conflicts.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.